Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrated commands to github actions #4701

Merged
merged 24 commits into from
Jun 18, 2024
Merged

Migrated commands to github actions #4701

merged 24 commits into from
Jun 18, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Jun 5, 2024

Migrated commands individually to work as GitHub actions with a workflow_dispatch event.

This will not disable the command-bot yet, but it's the first step before disabling it.

Commands migrated

  • bench-all
  • bench-overhead
  • bench
  • fmt
  • update-ui

Also created an action that will inform users about the new documentation when they comment bot.

Created documentation

Created a detailed documentation on how to use this action. Found the documentation here.

@Bullrich Bullrich self-assigned this Jun 5, 2024
@Bullrich Bullrich added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label Jun 5, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6402946

@Bullrich Bullrich force-pushed the bullrich/cmd-action branch from 9ced867 to 96d2208 Compare June 10, 2024 11:09
@Bullrich Bullrich force-pushed the bullrich/cmd-action branch from 72e28b1 to 0e2cbbc Compare June 17, 2024 12:14
@Bullrich Bullrich requested review from mordamax and alvicsam June 17, 2024 13:41
@Bullrich Bullrich marked this pull request as ready for review June 17, 2024 13:42
@Bullrich Bullrich requested review from a team as code owners June 17, 2024 13:42
@Bullrich
Copy link
Contributor Author

PR is ready for review.

@paritytech/ci can you please guide me on what machine I can use to run the bench tasks? As the latest-ubuntu doesn't have enough capacity to run those heavy tasks.

@Bullrich Bullrich force-pushed the bullrich/cmd-action branch from 69a0e3b to 82890e0 Compare June 17, 2024 13:42
@Bullrich Bullrich added R0-silent Changes should not be mentioned in any release notes and removed T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Jun 17, 2024
@Bullrich Bullrich changed the title [WIP] - Migrated commands to github actions Migrated commands to github actions Jun 17, 2024
@alvicsam
Copy link
Contributor

@Bullrich are these benches for weights? If not you can use arc-runners-polkadot-sdk-benchmark runners

@Bullrich
Copy link
Contributor Author

@Bullrich are these benches for weights? If not you can use arc-runners-polkadot-sdk-benchmark runners

This are for the weights, so I'm afraid we can't use arc-runners-polkadot-sdk-benchmark.

@Bullrich Bullrich force-pushed the bullrich/cmd-action branch from 82890e0 to 3339b9b Compare June 17, 2024 15:38
@alvicsam
Copy link
Contributor

The machines have the same specs, the only differences is that weights use persistent machines. I haven't added weights machines yet so you can test arc-runners-polkadot-sdk-benchmark for now

@Bullrich
Copy link
Contributor Author

The machines have the same specs, the only differences is that weights use persistent machines. I haven't added weights machines yet so you can test arc-runners-polkadot-sdk-benchmark for now

Thanks. I applied the machines for the bench jobs

@Bullrich Bullrich requested a review from alvicsam June 18, 2024 08:28
@Bullrich Bullrich force-pushed the bullrich/cmd-action branch from 3ee74b0 to cd6abc4 Compare June 18, 2024 12:49
@Bullrich Bullrich enabled auto-merge June 18, 2024 12:49
@Bullrich Bullrich added this pull request to the merge queue Jun 18, 2024
Merged via the queue into master with commit 6daa939 Jun 18, 2024
144 of 156 checks passed
@Bullrich Bullrich deleted the bullrich/cmd-action branch June 18, 2024 13:35
@Bullrich Bullrich mentioned this pull request Jun 18, 2024
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/command-bot-has-migrated-to-github-actions/8722/1

github-merge-queue bot pushed a commit that referenced this pull request Jul 12, 2024
Added the command sync. Follow up on #4701 

This PR is blocked until a new machine for the sync gets deployed.
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request Jul 13, 2024
Added the command sync. Follow up on paritytech#4701 

This PR is blocked until a new machine for the sync gets deployed.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Migrated commands individually to work as GitHub actions with a
[`workflow_dispatch`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch)
event.

This will not disable the command-bot yet, but it's the first step
before disabling it.

### Commands migrated
- [x] bench-all
- [x] bench-overhead
- [x] bench
- [x] fmt
- [x] update-ui

Also created an action that will inform users about the new
documentation when they comment `bot`.

### Created documentation 
Created a detailed documentation on how to use this action. Found the
documentation
[here](https://github.com/paritytech/polkadot-sdk/blob/bullrich/cmd-action/.github/commands-readme.md).

---------

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Przemek Rzad <przemek@parity.io>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Added the command sync. Follow up on paritytech#4701 

This PR is blocked until a new machine for the sync gets deployed.
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
Migrated commands individually to work as GitHub actions with a
[`workflow_dispatch`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch)
event.

This will not disable the command-bot yet, but it's the first step
before disabling it.

### Commands migrated
- [x] bench-all
- [x] bench-overhead
- [x] bench
- [x] fmt
- [x] update-ui

Also created an action that will inform users about the new
documentation when they comment `bot`.

### Created documentation 
Created a detailed documentation on how to use this action. Found the
documentation
[here](https://github.com/paritytech/polkadot-sdk/blob/bullrich/cmd-action/.github/commands-readme.md).

---------

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Przemek Rzad <przemek@parity.io>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
Added the command sync. Follow up on paritytech#4701 

This PR is blocked until a new machine for the sync gets deployed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants