Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adjust base value for statement-distribution regression tests #5028

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Adjust base value for statement-distribution regression tests #5028

merged 1 commit into from
Jul 16, 2024

Conversation

AndreiEres
Copy link
Contributor

A baseline for the statement-distribution regression test was set only in the beginning and now we see that the actual values a bit lower.

image

Source

@AndreiEres AndreiEres added R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Jul 16, 2024
@ordian ordian enabled auto-merge July 16, 2024 11:21
@ordian ordian added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 79a3d6c Jul 16, 2024
158 of 166 checks passed
@ordian ordian deleted the AndreiEres/statement-distr-regr-adjust branch July 16, 2024 12:02
ordian added a commit that referenced this pull request Jul 17, 2024
@ordian
Merge branch 'master' into ao-paraheadrootsprovider-coretime-fix
0f207dd 
* master:
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
jpserrat pushed a commit to jpserrat/polkadot-sdk that referenced this pull request Jul 18, 2024
@AndreiEres @jpserrat
Adjust base value for statement-distribution regression tests (parity…
b9e570f 
…tech#5028)

A baseline for the statement-distribution regression test was set only
in the beginning and now we see that the actual values a bit lower.

<img width="1001" alt="image"
src="https://github.com/user-attachments/assets/40b06eec-e38f-43ad-b437-89eca502aa66">


[Source](https://paritytech.github.io/polkadot-sdk/bench/statement-distribution-regression-bench)
ordian added a commit that referenced this pull request Jul 18, 2024
@ordian
Merge branch 'master' into ao-fix-backing-filtering-on-disputes
f75dcd7 
* master: (125 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@AndreiEres @TarekkMA
Adjust base value for statement-distribution regression tests (parity…
76623a3 
…tech#5028)

A baseline for the statement-distribution regression test was set only
in the beginning and now we see that the actual values a bit lower.

<img width="1001" alt="image"
src="https://github.com/user-attachments/assets/40b06eec-e38f-43ad-b437-89eca502aa66">


[Source](https://paritytech.github.io/polkadot-sdk/bench/statement-distribution-regression-bench)
ordian added a commit that referenced this pull request Aug 6, 2024
@ordian
Merge branch 'master' into ao-account-for-enact-candidate-weight
e6978fd 
* master: (130 commits)
  add elastic scaling MVP guide (#4663)
  Send PeerViewChange with high priority (#4755)
  [ci] Update forklift in CI image (#5032)
  Adjust base value for statement-distribution regression tests (#5028)
  [pallet_contracts] Add support for transient storage in contracts host functions (#4566)
  [1 / 5] Optimize logic for gossiping assignments (#4848)
  Remove `pallet-getter` usage from pallet-session (#4972)
  command-action: added scoped permissions to the github tokens (#5016)
  net/litep2p: Propagate ValuePut events to the network backend (#5018)
  rpc: add back rpc logger (#4952)
  Updated substrate-relay version for tests (#5017)
  Remove most all usage of `sp-std` (#5010)
  Use sp_runtime::traits::BadOrigin (#5011)
  network/tx: Ban peers with tx that fail to decode (#5002)
  Try State Hook for Bounties (#4563)
  [statement-distribution] Add metrics for distributed statements in V2 (#4554)
  added sync command (#4818)
  Bridges V2 refactoring backport and `pallet_bridge_messages` simplifications (#4935)
  xcm-executor: Improve logging (#4996)
  Remove usage of `sp-std` on templates (#5001)
  ...
This was referenced Aug 21, 2024
Closed
Closed
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
@AndreiEres
Adjust base value for statement-distribution regression tests (parity…
ef0b113 
…tech#5028)

A baseline for the statement-distribution regression test was set only
in the beginning and now we see that the actual values a bit lower.

<img width="1001" alt="image"
src="https://github.com/user-attachments/assets/40b06eec-e38f-43ad-b437-89eca502aa66">


[Source](https://paritytech.github.io/polkadot-sdk/bench/statement-distribution-regression-bench)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ordian ordian ordian approved these changes

@alexggh alexggh alexggh approved these changes

@sandreim sandreim sandreim approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreiEres @ordian @alexggh @sandreim