Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix doc: start_destroy doesn't need asset to be frozen #5204

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Aug 1, 2024

Fix #5184

owner can set himself as a freezer and freeze the asset so requirement is not really needed. And requirement is not implemented.

@gui1117 gui1117 requested a review from a team as a code owner August 1, 2024 06:51
@bkchr bkchr requested a review from muharem August 12, 2024 20:35
@gui1117
Copy link
Contributor Author

gui1117 commented Aug 15, 2024

should I do a PR doc ?

@ggwpez
Copy link
Member

ggwpez commented Aug 15, 2024

I will try if the bot works now for that. Not really needed in such simple cases, but its a bit cleaner since it triggers a re-publish of the crate in the next release.

@paritytech paritytech deleted a comment from github-actions bot Aug 15, 2024
@paritytech paritytech deleted a comment from github-actions bot Aug 15, 2024
@ggwpez
Copy link
Member

ggwpez commented Aug 15, 2024

Bot not yet working. You can add a prdoc with patch entries, but its not really needed here since the patch is not critical and will be picked up after another change triggers it.

@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Aug 16, 2024
@ggwpez ggwpez enabled auto-merge August 16, 2024 13:30
@ggwpez ggwpez added this pull request to the merge queue Aug 16, 2024
Merged via the queue into paritytech:master with commit fd522b8 Aug 16, 2024
182 of 183 checks passed
@gui1117 gui1117 deleted the gui-fix-5184 branch August 16, 2024 23:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pallet assets start_destroy() invalid doc comment or bug
4 participants