Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor verbose test #5506

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Refactor verbose test #5506

merged 4 commits into from
Aug 28, 2024

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Aug 28, 2024

A test is triggering a log error. But is correct and successful. This is a refactor without triggering the log error.

@gui1117 gui1117 requested a review from a team as a code owner August 28, 2024 02:12
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7155327

ggwpez
ggwpez approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the hashed_key_for is better, i did not realize it would spam so much 😅

@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Aug 28, 2024
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Aug 28, 2024
@bkchr bkchr enabled auto-merge August 28, 2024 14:41
@bkchr bkchr added this pull request to the merge queue Aug 28, 2024
Merged via the queue into paritytech:master with commit 97fa922 Aug 28, 2024
256 of 261 checks passed
@gui1117 gui1117 deleted the gui-refactor-verbose-test branch August 28, 2024 23:32
ordian added a commit that referenced this pull request Aug 29, 2024
@ordian
Merge branch 'master' into ao-enact-candidate-weight
629a541 
* master: (39 commits)
  short-term fix for para inherent weight overestimation (#5082)
  CI: Add backporting bot (#4795)
  Fix benchmark failures when using `insecure_zero_ed` flag (#5354)
  Command bot GHA v2 - /cmd <cmd> (#5457)
  Remove pallet::getter usage from treasury (#4962)
  Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404)
  Bump rustversion from 1.0.14 to 1.0.17 (#5405)
  Bridge zombienet tests: remove old command (#5434)
  polkadot-parachain: Add omni-node variant with u64 block number (#5269)
  Refactor verbose test (#5506)
  Use umbrella crate for minimal template (#5155)
  IBP Coretime Polkadot bootnodes (#5499)
  rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792)
  Update approval-voting-regression-bench (#5504)
  change try-runtime rpc domains (#5443)
  polkadot-parachain-bin: Remove contracts parachain (#5471)
  Add feature to allow Aura collator to use full PoV size (#5393)
  Adding stkd bootnodes (#5470)
  Make `PendingConfigs` storage item public (#5467)
  frame-omni-bencher maintenance (#5466)
  ...
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Closed
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gui1117 @paritytech-cicd-pr @bkchr @ggwpez