Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

pallet-bounties: Fix benchmarks for 0 ED #7013

Merged
merged 3 commits into from
Dec 30, 2024
Merged

pallet-bounties: Fix benchmarks for 0 ED #7013

merged 3 commits into from
Dec 30, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 29, 2024

Closes: #7009

@bkchr bkchr added T1-FRAME This PR/Issue is related to core FRAME, the framework. A4-needs-backport Pull request must be backported to all maintained releases. labels Dec 29, 2024
@bkchr bkchr requested a review from gui1117 December 29, 2024 22:05
@bkchr bkchr requested a review from a team as a code owner December 29, 2024 22:05
@bkchr
Copy link
Member Author

bkchr commented Dec 30, 2024

/cmd prdoc --audience runtime_dev --bump patch

@bkchr bkchr enabled auto-merge December 30, 2024 09:58
@bkchr bkchr added this pull request to the merge queue Dec 30, 2024
Merged via the queue into master with commit 997db8e Dec 30, 2024
198 of 201 checks passed
@bkchr bkchr deleted the bkchr-bounties-zero-ed branch December 30, 2024 11:06
@paritytech-cmd-bot-polkadot-sdk
Copy link

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7013-to-stable2407
git worktree add --checkout .worktree/backport-7013-to-stable2407 backport-7013-to-stable2407
cd .worktree/backport-7013-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 997db8e2035ce180f502ccb54eb06ab464d95dab
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 30, 2024
Merged
@paritytech-cmd-bot-polkadot-sdk
Copy link

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7013-to-stable2409
git worktree add --checkout .worktree/backport-7013-to-stable2409 backport-7013-to-stable2409
cd .worktree/backport-7013-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 997db8e2035ce180f502ccb54eb06ab464d95dab
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 30, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
@bkchr @github-actions
pallet-bounties: Fix benchmarks for 0 ED (#7013)
9d36a64 
Closes: #7009

---------

Co-authored-by: command-bot <>
(cherry picked from commit 997db8e)
@paritytech-cmd-bot-polkadot-sdk
Copy link

Successfully created backport PR for stable2412:

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 30, 2024
Merged
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
@bkchr @dudo50
pallet-bounties: Fix benchmarks for 0 ED (paritytech#7013)
7abdbfa 
Closes: paritytech#7009

---------

Co-authored-by: command-bot <>
ordian added a commit that referenced this pull request Jan 7, 2025
@ordian
Merge branch 'master' into ao-fix-issue-64
b4fea58 
* master: (256 commits)
  fix chunk fetching network compatibility zombienet test (#6988)
  chore: delete repeat words (#7034)
  Print taplo version in CI (#7041)
  Implement cumulus StorageWeightReclaim as wrapping transaction extension + frame system ReclaimWeight (#6140)
  Make `TransactionExtension` tuple of tuple transparent for implication (#7028)
  Replace duplicated whitelist with whitelisted_storage_keys (#7024)
  [WIP] Fix networking-benchmarks (#7036)
  [docs] Fix release naming (#7032)
  migrate pallet-mixnet to umbrella crate (#6986)
  Improve remote externalities logging (#7021)
  Fix polkadot sdk doc. (#7022)
  Remove warning log from frame-omni-bencher CLI (#7020)
  [pallet-revive] fix file case (#6981)
  Add workflow for networking benchmarks (#7029)
  [CI] Skip SemVer on R0-silent and update docs (#6285)
  correct path in cumulus README (#7001)
  sync: Send already connected peers to new subscribers (#7011)
  Excluding chainlink domain for link checker CI (#6524)
  pallet-bounties: Fix benchmarks for 0 ED (#7013)
  Log peerset set ID -> protocol name mapping (#7005)
  ...
EgorPopelyaev added a commit that referenced this pull request Jan 10, 2025
@paritytech-cmd-bot-polkadot-sdk @bkchr @EgorPopelyaev
[stable2407] Backport #7013 (#7015)
92e4d83 
Backport #7013 into `stable2407` from bkchr.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: EgorPopelyaev <egor@parity.io>
EgorPopelyaev pushed a commit that referenced this pull request Jan 14, 2025
@paritytech-cmd-bot-polkadot-sdk @bkchr
[stable2412] Backport #7013 (#7017)
855703f 
Backport #7013 into `stable2412` from bkchr.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Bastian Köcher <git@kchr.de>
EgorPopelyaev added a commit that referenced this pull request Jan 14, 2025
@paritytech-cmd-bot-polkadot-sdk @bkchr @EgorPopelyaev
[stable2409] Backport #7013 (#7016)
9f35731 
Backport #7013 into `stable2409` from bkchr.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: EgorPopelyaev <egor@parity.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@seadanda seadanda seadanda approved these changes

Assignees
No one assigned
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to properly benchmark pallet_bounties when ED is 0
3 participants
@bkchr @gui1117 @seadanda