Remove usage of sp-std from Substrate
#7043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
reviewed
Jan 5, 2025
bkchr
reviewed
Jan 5, 2025
| @@ -1051,6 +1051,29 @@ pub use alloc::borrow::Cow; | |||
| #[deprecated = "Use String or Cow<'static, str> instead"] | |||
| pub type RuntimeString = alloc::string::String; | |||
|
|
|||
| /// A target for `core::write!` macro - constructs a string in memory. | |||
| #[derive(Default)] | |||
| pub struct Writer(vec::Vec<u8>); | |||
There was a problem hiding this comment.
We could just replace the usage of writer with alloc::string::String to no require a custom type.
There was a problem hiding this comment.
That's great to hear! My concern, however, is that, as far as I know, using alloc::string::String is discouraged to avoid bloating the runtime size.
| @@ -650,7 +650,7 @@ fn expand_functions(def: &EnvDef, expand_mode: ExpandMode) -> TokenStream2 { | |||
| let result = #body; | |||
| if ::log::log_enabled!(target: "runtime::contracts::strace", ::log::Level::Trace) { | |||
| use core::fmt::Write; | |||
| let mut w = sp_std::Writer::default(); | |||
| let mut w = sp_runtime::Writer::default(); | |||
There was a problem hiding this comment.
Suggested change
| let mut w = sp_runtime::Writer::default(); | |
| let mut w = alloc::string::String::default(); |
bkchr
added
the
T17-primitives
bkchr
approved these changes
Jan 6, 2025
|
/cmd prdoc --bump patch --audience runtime_dev --force |
gui1117
approved these changes
Jan 6, 2025
Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io>
athei
approved these changes
Jan 6, 2025
pgherveou
approved these changes
Jan 7, 2025
Merged
via the queue into
paritytech:master
with commit Jan 7, 2025
c139739
199 of 203 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes usage of deprecated
sp-stdfrom Substrate. (following PR of #5010)Integration
This PR doesn't remove re-exported
sp_stdfrom any crates yet, so downstream projects using re-exportedsp_stdwill not be affected.Review Notes
The existing code using
sp-stdis refactored to useallocandcoredirectly. The key-value maps are instantiated from a vector of tuples directly instead of usingsp_std::map!macro.sp_std::Writeris a helper type to useVec<u8>withcore::fmt::Writetrait. This PR copied it intosp-runtime, because all crates usingsp_std::Writer(includingsp-runtimeitself,frame-support, etc.) depend onsp-runtime.If this PR is merged, I would write following PRs to remove remaining usage of
sp-stdfrombridgesandcumulus.