This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Companion for #6610 (Balances Weight Trait) #1425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
gui1117
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good to me,
But how is update of weight integrated into CI ? will it be manual for each runtime release ?
@thiolliere CI is not integrated yet. Will need to work on that too at some point.... :| But need to migrate things first I think |
bot merge |
Missing process info; check that the PR belongs to a project column. |
bot merge |
Missing process info; check that the PR belongs to a project column. |
ordian
added a commit
that referenced
this pull request
Jul 31, 2020
* master: Candidate Validation Subsystem (#1432) reduce slash defer durations (#1504) Implement the Runtime API subsystem (#1494) Companion for #6610 (Balances Weight Trait) (#1425) [CI] Publish draft release redux (#1493) Update README docs related to local build (#1479) Add a default trie-memory-tracker feature to the cli (#1502) Companion PR for `Add a `DefaultQueue` type alias to remove the need to use `sp_api::TransactionFor`` (#1499) Fix bitfield signing (#1466) Update Substrate, bump versions, clean up sort (#1496) Bump Substrate
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
A0-please_review
Pull request needs code review.
A4-companion
A PR that needs a companion PR to merge in parallel for one of its downstream dependencies.
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion for: paritytech/substrate#6610
This updates to new "extra" param in the benchmarking pipeline, and adds weights to each of the 3 production runtimes for the balances pallet.
Weight Comparison