This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add new Runtime API messages and make runtime API request fallible #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
coriolinus
approved these changes
Jul 28, 2020
|
bot merge |
|
Trying merge. |
ghost
merged commit
I agree, although I am not sure if there is a unifying theme here other than "this shouldn't take down the node" |
This pull request was closed.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1419
This updates the
RuntimeApiMessageto match thev1::ParachainHostAPIs. It also updates the requests to be fallible, in case an internal error is encountered. And lastly, it updates all existing subsystems to handle this fallibility in a way which doesn't take the node down, and updates them to use the new runtime APIs.