Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update for JSON-RPC spec change #2994

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 9, 2022

Update for paritytech/json-rpc-interface-spec#26

To be merged only after that PR is approved and merged.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      +42137 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hb26bc18367bb5407
      -42137 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::hdec7a5ebc0d70639
      -12041 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h8485efb39b44ea63
      +12041 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hadfa9a1058999569
       -3669 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::h47740c40a92dcab9
       +3669 ┊ <smoldot::json_rpc::methods::MethodCall as core::fmt::Debug>::fmt::hd56d6cfd5778e94c
       -1514 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::h11268d97431fbe81
       +1514 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::h51f8986cab4dcdbd
        +586 ┊ core::ptr::drop_in_place<smoldot::json_rpc::methods::MethodCall>::h38c1e86447310413
        -586 ┊ core::ptr::drop_in_place<smoldot::json_rpc::methods::MethodCall>::h8e098fd940fb5191
        +308 ┊ smoldot::json_rpc::methods::parse_json_call::h6de156094e74e8e5
        -308 ┊ smoldot::json_rpc::methods::parse_json_call::hdbba71bb19a0764a
        -267 ┊ serde_json::de::from_trait::h8666003031467dd9
        +267 ┊ serde_json::de::from_trait::h9aab57eb76b8c59e
         +62 ┊ serde_json::de::from_str::h2ebd77ccb26886af
         -62 ┊ serde_json::de::from_str::h5388744a48c87460
         -46 ┊ smoldot::json_rpc::methods::MethodCall::name::h519fde0761a17842
         +46 ┊ smoldot::json_rpc::methods::MethodCall::name::hdbc16bb37105a52d
         -34 ┊ core::ptr::drop_in_place<core::result::Result<smoldot::json_rpc::methods::MethodCall::from_defs::Params,serde_json::error::Error>>::h4e6e24c8d898f1b5
         +34 ┊ core::ptr::drop_in_place<core::result::Result<smoldot::json_rpc::methods::MethodCall::from_defs::Params,serde_json::error::Error>>::hb96d617fa9214af6
          +0 ┊ ... and 4 more.
          +0 ┊ Σ [24 Total Rows]

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants