Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sync tx submission with chainHead_follow #1305

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Dec 4, 2023

Takes what #1300 does and moves it to a lower level, so that the unstable backend's submit_transaction function itself guarantees to be in sync with other backend functions.

Closes: #1248
Closes: #1240

@jsdw jsdw requested a review from a team as a code owner December 4, 2023 11:42
@jsdw jsdw changed the title sync tx submission with chainHead_follow Sync tx submission with chainHead_follow Dec 4, 2023
Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

@jsdw
Copy link
Collaborator Author

jsdw commented Dec 4, 2023

Nice one! 👍

Oh, you did all of the actual hard work in finding out what the issue was :)

@jsdw jsdw merged commit c3b4331 into master Dec 4, 2023
@jsdw jsdw deleted the jsdw-sync-tx-and-chainhead branch December 4, 2023 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants