Refactor: extract functions and types for creating extrinsics #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
changed the title
|
@niklasad1 I think remember you asking a while ago in Riot about constructing extrinsics offline - maybe this PR would be useful. /cc @dvdplm |
Demi-Marie
reviewed
Jul 20, 2020
| @@ -47,6 +47,7 @@ substrate-subxt-proc-macro = { version = "0.9.0", path = "proc-macro" } | |||
| async-std = { version = "=1.5.0", features = ["attributes"] } | |||
| env_logger = "0.7.1" | |||
| wabt = "0.9.2" | |||
| wabt-sys = "=0.7.1" # pinned because 0.7.2 fails to compile | |||
There was a problem hiding this comment.
This needs to be reported against wabt-sys.
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the types and routines for creating extrinsics from the client so they can be used independently of the
Clientto construct extrinsics.todo