Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Only return an error if the extrinsic failed. #156

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Only return an error if the extrinsic failed. #156

merged 1 commit into from
Sep 1, 2020

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Aug 30, 2020

If an extrinsic in a block fails, all extrinsics will report a failure. We check the phase when watching an extrinsic and ignore errors of other extriniscs.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Aug 31, 2020

All tests pass, it's a transient error. Not sure why we keep getting virual method called after the test runner completes.

ascjones
ascjones approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones
Copy link
Contributor

ascjones commented Sep 1, 2020

All tests pass, it's a transient error. Not sure why we keep getting virual method called after the test runner completes.

Yeah that keeps happening, perhaps something to do with the test client?

@ascjones ascjones merged commit e9c50e2 into paritytech:master Sep 1, 2020
@ascjones ascjones mentioned this pull request Sep 1, 2020
Merged
dvdplm added a commit that referenced this pull request Sep 15, 2020
@dvdplm
Merge branch 'master' into staking
773d43e 
* master:
  decode option event arg (#158)
  Release v0.12.0 (#157)
  Only return an error if the extrinsic failed. (#156)
  Update to rc6. (#155)
  Different assert. (#153)
  Add a method to fetch an unhashed key, close #100 (#152)
  Fix port number. (#151)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvc94ch @ascjones