Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add event Phase::Initialization #215

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

h4x3rotab
Copy link
Contributor

@h4x3rotab h4x3rotab commented Jan 8, 2021

@h4x3rotab h4x3rotab force-pushed the update-system-frame branch from c558350 to 22d544c Compare January 8, 2021 21:01
@h4x3rotab
Copy link
Contributor Author

The build is failed due to an upstream compiling issue paritytech/substrate#7844

@h4x3rotab
Copy link
Contributor Author

Could we rerun the CI?

@niklasad1
Copy link
Member

Funny thing, we run into libp2p/rust-libp2p#1912 now :(

@emostov
Copy link
Contributor

emostov commented Jan 12, 2021

@niklasad1 would bumping to parity-multiaddr-0.10.1 fix this (the version that was published 6 hours ago)?

@niklasad1
Copy link
Member

would bumping to parity-multiaddr-0.10.1 fix this (the version that was published 6 hours ago)?

Yes if it would be a direct dependency but unfortunately, in this case, it's fetched via sc-network which depends on an old version of libp2p so we are blocked until a new release :(

Still, I think it's fine the merge this PR anyway

@emostov
Copy link
Contributor

emostov commented Jan 12, 2021

Still, I think it's fine the merge this PR anyway

@niklasad1 (@dvdplm) who makes the final call on this?

@niklasad1
Copy link
Member

I think it is up to @ascjones :)

However, the fix is being backported to parity-multiaddr 0.9 so let's wait for it,

@ascjones ascjones merged commit 754b184 into paritytech:master Jan 14, 2021
@ascjones ascjones mentioned this pull request Feb 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants