Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move Subxt crate into a subfolder #424

Merged
merged 7 commits into from
Feb 2, 2022
Merged

Move Subxt crate into a subfolder #424

merged 7 commits into from
Feb 2, 2022

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Feb 2, 2022

This paves the way for #406, given that for that we'll want to break out a couple of other crates.

An unfortunate side effect is that examples end up in the subxt subfolder; I've updated the README to point people there, but probably they should be placed into a separate crate in the workspace so that we get a top level examples folder back. Happy to leave that for a next PR though.

@jsdw
Copy link
Collaborator Author

jsdw commented Feb 2, 2022

I moved the examples into their own workspace crate as I didn't like that they weren't so visible in the root.

@@ -0,0 +1,3 @@
# Subxt Examples

Take a look in the [examples](./examples) subfolder for various `subxt` usage examples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can go into the main README?

@@ -1,53 +1,10 @@
[workspace]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[workspace]
[workspace]
resolver = "2"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@jsdw jsdw Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find any docs on this? I can't find anything suggesting that this is a valid addition offhand, but it kindof makes sense!

All of the subcrates are "edition = 2021", which implies "resolver = 2" by default. But since resolution happens globally, is this important too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, found it! I must have skimmed the relevant part of the docs before :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ah sorry @ascjones; I hadn't seen your reply)

@jsdw jsdw merged commit 55f04c2 into master Feb 2, 2022
@jsdw jsdw deleted the jsdw-subxt-subfolder branch February 2, 2022 12:15
0623forbidden pushed a commit to DEIPworld/substrate-subxt that referenced this pull request Feb 15, 2022
* move into subfolder step 1

* Make folders a workspace again

* Move examples into their own workspace crate to make them more visible and easier to run

* clippy fix

* newline

* tweak releasing steps for folder move

* reference exampels more clearly in top level readme
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants