-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move Subxt crate into a subfolder #424
Conversation
I moved the examples into their own workspace crate as I didn't like that they weren't so visible in the root. |
@@ -0,0 +1,3 @@ | |||
# Subxt Examples | |||
|
|||
Take a look in the [examples](./examples) subfolder for various `subxt` usage examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can go into the main README
?
@@ -1,53 +1,10 @@ | |||
[workspace] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[workspace] | |
[workspace] | |
resolver = "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default for Rust 2021 https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you find any docs on this? I can't find anything suggesting that this is a valid addition offhand, but it kindof makes sense!
All of the subcrates are "edition = 2021", which implies "resolver = 2" by default. But since resolution happens globally, is this important too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, found it! I must have skimmed the relevant part of the docs before :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ah sorry @ascjones; I hadn't seen your reply)
* move into subfolder step 1 * Make folders a workspace again * Move examples into their own workspace crate to make them more visible and easier to run * clippy fix * newline * tweak releasing steps for folder move * reference exampels more clearly in top level readme
This paves the way for #406, given that for that we'll want to break out a couple of other crates.
An unfortunate side effect is that examples end up in thesubxt
subfolder; I've updated the README to point people there, but probably they should be placed into a separate crate in the workspace so that we get a top levelexamples
folder back. Happy to leave that for a next PR though.