-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add custom derives for specific generated types #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Apr 27, 2022
lexnv
reviewed
Apr 27, 2022
lexnv
reviewed
Apr 27, 2022
lexnv
reviewed
Apr 27, 2022
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
…/specific-type-derive
lexnv
approved these changes
Apr 28, 2022
jsdw
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user can only specify custom derives to be applied to all generated types. Sometimes it is required to use a specific generated type with certain requirements e.g.
Ord, PartialOrd
orserde::Serialize, serde::Deserialize
, however it is not always possible/desirable to implement those on all generated types. For example when used in conjuction withsubstitute_type
where the substituted type does not implement the required derives.This PR adds the ability to specify derives for specific generated types, by adding the
derive_for_type
configuration to thesubxt
attribute:Note also that
generated_type_derives
has been renamed toderive_for_all_types
.The final set of derives applied to a specified type will be the union of
default_derives
+user_derive_for_all_types
+user_derive_for_type
.todo
cargo-contract