Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use minimum amount of dependencies for crates #524

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Use minimum amount of dependencies for crates #524

merged 4 commits into from
Apr 29, 2022

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Apr 29, 2022

Reduce the number of dependencies for isolated crates.
This will greatly benefit developers that want to work with a subset of
subxt crates, as redundant crates are no longer included in the Cargo.toml.

One real benefit of the trimming of dependencies is the chameleon crate.

lexnv added 4 commits April 29, 2022 12:42
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff! Looks good to me :)

@jsdw jsdw requested a review from ascjones April 29, 2022 12:56
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ascjones ascjones merged commit b32cd32 into master Apr 29, 2022
@ascjones ascjones deleted the reduce_deps branch April 29, 2022 14:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants