Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add topics to EventDetails #989

Merged
merged 4 commits into from
May 31, 2023
Merged

Add topics to EventDetails #989

merged 4 commits into from
May 31, 2023

Conversation

ascjones
Copy link
Contributor

Topics are actually used in pallet-contracts, and we will need access to them for upcoming changes to ink! events.

@ascjones ascjones requested a review from a team as a code owner May 31, 2023 11:03
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ascjones ascjones merged commit 011a4bd into master May 31, 2023
@ascjones ascjones deleted the aj/event-topics branch May 31, 2023 12:10
@jsdw jsdw mentioned this pull request Jun 1, 2023
tadeohepperle pushed a commit that referenced this pull request Jun 1, 2023
* Add topics to `EventDetails`

* Update comment

* Fmt

* Clippy
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants