Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

on-runtime-upgrade should enforce migrations are idempotent #42

Closed
liamaharon opened this issue Oct 17, 2023 · 0 comments · Fixed by #48
Closed

on-runtime-upgrade should enforce migrations are idempotent #42

liamaharon opened this issue Oct 17, 2023 · 0 comments · Fixed by #48
Assignees
@liamaharon
Labels
enhancement New feature or request

Comments

@liamaharon
Copy link
Contributor

See paritytech/polkadot-sdk#1921 (comment)

Should enforce by default, and allow skipping by specifying a CLI flag.
@liamaharon liamaharon added enhancement New feature or request good first issue Good for newcomers labels Oct 17, 2023
@liamaharon liamaharon mentioned this issue Oct 17, 2023
Merged
@liamaharon liamaharon removed the good first issue Good for newcomers label Oct 30, 2023
@liamaharon liamaharon self-assigned this Oct 30, 2023
@liamaharon liamaharon mentioned this issue Oct 30, 2023
Merged
liamaharon added a commit to paritytech/polkadot-sdk that referenced this issue Oct 30, 2023
@liamaharon
contracts migration: remove unnecessary panics (#2079)
ad5163b 
Runtime migration CI is currently failing
(https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/4122083)
for the contracts testnet due to unnecessary panicing in a `pre_upgrade`
hook.

Soon idempotency will be enforced
paritytech/try-runtime-cli#42, in the mean
time we need to manually fix these issues as they arise.

---

also removes backticks from the string in `echo`, which caused a
'command not found' error in ci output
@liamaharon liamaharon mentioned this issue Oct 31, 2023
Merged
liamaharon added a commit that referenced this issue Nov 10, 2023
@liamaharon @ggwpez
Add migration idempotency checks (#48)
f621966 
Closes #42 

Checks that `on_runtime_upgrade` succeeds when called twice, and if it
does succeed after being called twice, the storage state root did not
change.

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@liamaharon
contracts migration: remove unnecessary panics (paritytech#2079)
93e0f18 
Runtime migration CI is currently failing
(https://gitlab.parity.io/parity/mirrors/polkadot-sdk/builds/4122083)
for the contracts testnet due to unnecessary panicing in a `pre_upgrade`
hook.

Soon idempotency will be enforced
paritytech/try-runtime-cli#42, in the mean
time we need to manually fix these issues as they arise.

---

also removes backticks from the string in `echo`, which caused a
'command not found' error in ci output
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@liamaharon liamaharon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add migration idempotency checks paritytech/try-runtime-cli
1 participant
@liamaharon