-
-
Notifications
You must be signed in to change notification settings - Fork 736
feat: Add support for uploading a ParseFile
from a URI
#1207
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Thanks for opening this pull request!
|
I added some tests but could not test it using a content uri, only from file uris |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 122 124 +2
Lines 9971 10076 +105
Branches 1345 1359 +14
=======================================
- Misses 9971 10076 +105 ☔ View full report in Codecov by Sentry. |
Please see the failing CI |
ParseFile
from a URI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@rommansabbir Thanks for reviewing |
# [4.3.0](4.2.1...4.3.0) (2024-02-18) ### Features * Add support for uploading a `ParseFile` from a URI ([#1207](#1207)) ([83aec68](83aec68))
🎉 This change has been released in version 4.3.0 |
New Pull Request Checklist
Issue Description
Adds support for uploading a
ParseFile
from aUri
.Closes: #1206
Approach
Followed the code from how it works using a File and byte[].
TODOs before merging