Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix Installation timezone TODO. #186

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Fix Installation timezone TODO. #186

merged 1 commit into from
Jun 3, 2019

Conversation

yulingtianxia
Copy link
Contributor

No description provided.

phillwiggins
phillwiggins reviewed Jun 3, 2019
View reviewed changes
Copy link
Member

@phillwiggins phillwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that FlutterNativeTimezone isn't platform dependant?

@yulingtianxia
Copy link
Contributor Author

@phillwiggins FlutterNativeTimezone use channel to call iOS/Android API.

@phillwiggins phillwiggins merged commit c8c1878 into parse-community:master Jun 3, 2019
@yulingtianxia yulingtianxia deleted the fix_installation_todo branch June 4, 2019 06:49
@phillwiggins phillwiggins mentioned this pull request Jun 18, 2019
Closed
fischerscode pushed a commit to fischerscode/Parse-SDK-Flutter that referenced this pull request Sep 5, 2020
@yulingtianxia @phillwiggins
Fix Installation timezone TODO. (parse-community#186)
ac0de7c
@vanyasem
Copy link

vanyasem commented Feb 1, 2022

Why was this merge request reverted?

@vanyasem vanyasem mentioned this pull request Feb 1, 2022
Closed
@mtrezza
Copy link
Member

mtrezza commented Feb 6, 2022

Can you find the PR that reverted this?

@vanyasem
Copy link

vanyasem commented Feb 6, 2022

It was first introduced in release 1.0.22 - https://github.com/parse-community/Parse-SDK-Flutter/commits/release/1.0.22/lib/src/objects

But in release 1.0.23 it's already gone - 130121e#diff-c37936a338cd43591644ae6be29c5da6ee8b18fd681cb3c584f417b8c9017f24

@vanyasem
Copy link

vanyasem commented Feb 6, 2022

image

@RodrigoSMarques
Copy link
Contributor

To use this package it is necessary to include consistency for Flutter WEB, as there is no support.

For this reason the PR was scrapped.

If you don't use Flutter Web, you can include the call directly in your project, after creating the Installation.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@phillwiggins phillwiggins phillwiggins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yulingtianxia @vanyasem @mtrezza @RodrigoSMarques @phillwiggins