update examples #205
Closed
update examples #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unreal0
commented
Jun 23, 2019
unreal0
commented
- update gradle to 5.1
- add livequery example
| @@ -101,7 +103,7 @@ class LiveQuery { | |||
| if (_debug) { | |||
| print('$_printConstLiveQuery: Done'); | |||
| } | |||
| }, onError: (Error error) { | |||
| }, onError: (error) { | |||
There was a problem hiding this comment.
Is this necessary? All variables should have Types inferred
There was a problem hiding this comment.
Yes , I don't know why it doesn't work when you define the type it's throw exception.
There was a problem hiding this comment.
The inferred type in onError is "Object" not "Error".
onError: (Object o) {
Error error = o;
}
or
You can leave the type, dart will assign the type Object when passing to function.
| @@ -121,10 +124,10 @@ class _ParseResponseBuilder { | |||
| /// Handles a response with a single result object | |||
| T _handleSingleResult<T>( | |||
| T object, Map<String, dynamic> map, bool createNewObject) { | |||
| if (createNewObject && object is ParseCloneable) { | |||
| return object.clone(map); | |||
| } else if (object is ParseObject) { | |||
There was a problem hiding this comment.
Why has this changed? It works correctly now? Seems like an unnecessary change?
phillwiggins
suggested changes
Jul 17, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.