Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MergeWithPrevious change #240

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

WangPerryWPY
Copy link
Contributor

The method of setAdd, setRemove, setAddAll, setRemoveAll, Increment, AddUnique, AddRelation, RemoveRelation can be merged between the same operation and some other operation. Implementation method reference iOS SDK. I do this by Implementing a tool class in "parse_merge.dart" and calling the "mergeWithPrevious" Method in the set method which implemented in parse_base.dart.

…Decrement, AddUnique, AddRelation, RemoveRelation can be merged between the same operation and some other operation. Implementation method reference iOS SDK. I do this by Implementing a tool class in "parse_merge.dart" and calling the "mergeWithPrevious" Method in the set method which implemented in parse_base.dart.
Copy link
Member

@phillwiggins phillwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! Is it all tried and tested?

@phillwiggins
Copy link
Member

Great work!

Will merge once checks have finished

@WangPerryWPY
Copy link
Contributor Author

WangPerryWPY commented Aug 7, 2019 via email

@phillwiggins phillwiggins merged commit 7a8cee1 into parse-community:release/1.0.23 Aug 7, 2019
@RodrigoSMarques
Copy link
Contributor

@WangPerryWPY
I did not understand the change.
These methods already work this way today.
Can you explain the advantage of this change over the previous implementation?

@WangPerryWPY
Copy link
Contributor Author

WangPerryWPY commented Aug 7, 2019 via email

@pastordee
Copy link
Contributor

Hi the same thing needs to be done with queryBuilder as well, e.g if you say
.. orderByDescending('online')
.. orderByDescending('last-seen');

to order online first and then last seen,
only the online(first one) works, the last seen is not in order but on iOS SDK and ANDROID SDK it works

@RodrigoSMarques
Copy link
Contributor

@pastordee
I had not tested it.
I'm doing a PR with the fix

@RodrigoSMarques
Copy link
Contributor

@phillwiggins and @pastordee
#241

fischerscode pushed a commit to fischerscode/Parse-SDK-Flutter that referenced this pull request Sep 5, 2020
* The method of setAdd, setRemove, setAddAll, setRemoveAll, Increment, Decrement, AddUnique, AddRelation, RemoveRelation can be merged between the same operation and some other operation. Implementation method reference iOS SDK. I do this by Implementing a tool class in "parse_merge.dart" and calling the "mergeWithPrevious" Method in the set method which implemented in parse_base.dart.

*  remove the commented out code.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants