Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Downgrade collection dependency to ^1.16.0 for compatibility with Flutter >=3.3 #880

Merged
merged 12 commits into from
May 14, 2023

Conversation

Nidal-Bakir
Copy link
Member

@Nidal-Bakir Nidal-Bakir commented May 13, 2023

New Pull Request Checklist

Issue Description

The collection dependency ^1.17.1 makes the Parse Dart SDK incompatible with the flutter_test dependency of Flutter <3.10.0. To continue support Flutter >= 3.3, the collection dependency needs to be downgraded.

Approach

Downgrade collection dependency to ^1.16.0.

TODO

  • Add cangelog entry

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 13, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ca8721) 38.68% compared to head (96d589a) 38.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   38.68%   38.68%           
=======================================
  Files          56       56           
  Lines        3278     3278           
=======================================
  Hits         1268     1268           
  Misses       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nidal-Bakir
Copy link
Member Author

I will test here also.
I will upgrade the Parse SDK version in the Flutter package to ^5.0.0 to see if everything is good and then revert back

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented May 13, 2023

OMG, I forgot that Flutter SDK will get the Dart SDK from pub. I really need to sleep.... o-O

And I'm wondering why its falling

@mtrezza mtrezza changed the title fix: Downgrade the collection dependency to 1.16.0 feat: Downgrade the collection dependency to ^1.16.0 for compatibility with Flutter 3.3 - 3.7 May 13, 2023
@mtrezza mtrezza changed the title feat: Downgrade the collection dependency to ^1.16.0 for compatibility with Flutter 3.3 - 3.7 feat: Downgrade collection dependency to ^1.16.0 for compatibility with Flutter 3.3 - 3.7 May 13, 2023
@mtrezza mtrezza changed the title feat: Downgrade collection dependency to ^1.16.0 for compatibility with Flutter 3.3 - 3.7 feat: Downgrade collection dependency to ^1.16.0 for compatibility with Flutter >=3.3 May 13, 2023
This reverts commit 067798d.
This reverts commit e45864c.
@mtrezza
Copy link
Member

mtrezza commented May 13, 2023

Yes, we just need to add the changelog entry.

Since this is lowering the collection dependency it seems more of a feat (more compatibility) than fix.

@mtrezza
Copy link
Member

mtrezza commented May 13, 2023

Oh why is the Flutter CI now passing? Don't we have to make a Dart release first? Or is Flutter using the local Parse Dart SDK?

@Nidal-Bakir
Copy link
Member Author

Nidal-Bakir commented May 14, 2023

because the Dart SDK 4.0.0 do not depend on collection 1.17.1

we are still using Dart SDK 4.x.x

@mtrezza
Copy link
Member

mtrezza commented May 14, 2023

Oh right, this is confusing, could you add the changelog entry, then we can merge this, I'll make a release and we should be able to merge #868.

@Nidal-Bakir
Copy link
Member Author

sure

@Nidal-Bakir
Copy link
Member Author

or should it be 5.1.0?

@mtrezza
Copy link
Member

mtrezza commented May 14, 2023

Yes

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for CI to pass...

@mtrezza mtrezza merged commit 8dce6fc into parse-community:master May 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants