-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Downgrade collection dependency to ^1.16.0
for compatibility with Flutter >=3.3
#880
feat: Downgrade collection dependency to ^1.16.0
for compatibility with Flutter >=3.3
#880
Conversation
Thanks for opening this pull request!
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 38.68% 38.68%
=======================================
Files 56 56
Lines 3278 3278
=======================================
Hits 1268 1268
Misses 2010 2010 ☔ View full report in Codecov by Sentry. |
I will test here also. |
OMG, I forgot that Flutter SDK will get the Dart SDK from pub. I really need to sleep.... o-O And I'm wondering why its falling |
^1.16.0
for compatibility with Flutter 3.3 - 3.7
^1.16.0
for compatibility with Flutter 3.3 - 3.7^1.16.0
for compatibility with Flutter 3.3 - 3.7
^1.16.0
for compatibility with Flutter 3.3 - 3.7^1.16.0
for compatibility with Flutter >=3.3
Yes, we just need to add the changelog entry. Since this is lowering the collection dependency it seems more of a |
Oh why is the Flutter CI now passing? Don't we have to make a Dart release first? Or is Flutter using the local Parse Dart SDK? |
because the Dart SDK 4.0.0 do not depend on collection 1.17.1 we are still using Dart SDK 4.x.x |
Oh right, this is confusing, could you add the changelog entry, then we can merge this, I'll make a release and we should be able to merge #868. |
sure |
or should it be 5.1.0? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, waiting for CI to pass...
New Pull Request Checklist
Issue Description
The collection dependency ^1.17.1 makes the Parse Dart SDK incompatible with the
flutter_test
dependency of Flutter <3.10.0. To continue support Flutter >= 3.3, the collection dependency needs to be downgraded.Approach
Downgrade collection dependency to ^1.16.0.
TODO