feat: Add support for Dart 3.1, remove support for Dart 2.18

[mbfakourii]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

Closes: #968

Approach

Improve support policy and CI

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)

[parse-github-assistant]

Thanks for opening this pull request!

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1ae0808) 39.60% compared to head (f1ce3b7) 39.60%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   39.60%   39.60%           
=======================================
  Files          60       60           
  Lines        3333     3333           
=======================================
  Hits         1320     1320           
  Misses       2013     2013           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mbfakourii]

Not sure this would be possible. These are major versions and there may be breaking changes. We already have a range with parse_server_sdk: ^5.1.2, the flutter SDK just needs to use the published version; not the local version.

We currently do not use the local version.
The reason for the CI error is related to the remove of support from version 2.18

The error in Flutter 3.3 is as follows:

ERR : The current Dart SDK version is 2.18.6.
    | 
    | Because parse_server_sdk requires SDK version >=2.19.6 <4.0.0, version solving failed.

We removed 2.18.6 and it is not supported in Flutter 3.3

I think there is no problem !

[mtrezza]

How is this possible if we did not actually remove Dart 2.18 support yet? It's only removed in this PR, not in the published Parse Dart SDK version.

[mbfakourii]

I think the problem was found !
The issue here is that we are checking the Parse Dart package in the Flutter section of CI.

[mtrezza]

Makes sense, can we remove this line from the CI?

[mbfakourii]

Makes sense, can we remove this line from the CI?

I think to remove this line, it is better to do PR flutter.

What is your opinion about the separation of two CI (flutter and dart)?

[mtrezza]

Sure, so should the line be removed in #971 (review)?

[mbfakourii]

@mtrezza

What do you think about melos?

[mtrezza]

I think you already identified the solution in #969 (comment). If you just remove the checking in the flutter section of the CI in the #971 (review) PR, then all these changes of splitting up the CI are unnecessary. We also want to keep the CI files as uniform as possible across repositories, for easier maintenance, so creating 2 files here if not necessary should be avoided if possible.

[mbfakourii]

I think you already identified the solution in #969 (comment). If you just remove the checking in the flutter section of the CI in the #971 (review) PR, then all these changes of splitting up the CI are unnecessary. We also want to keep the CI files as uniform as possible across repositories, for easier maintenance, so creating 2 files here if not necessary should be avoided if possible.

But didn't you say to separate it here?

[mtrezza]

Yes, remove the line in the flutter PR #971 (or adapt the CI so that Dart is not tested when running the flutter CI, without using path in the CI), so we can merge the flutter PR first, then rebase this PR and there won't be any issues anymore, right?

[mbfakourii]

Yes, remove the line in the flutter PR #971 (or adapt the CI so that Dart is not tested when running the flutter CI, without using path in the CI), so we can merge the flutter PR first, then rebase this PR and there won't be any issues anymore, right?

Done, please check again

[mtrezza]

Looks good, waiting for CI to pass...