fix: ParseUser.linkWith doesn't remove anonymous auth data
#2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #2007 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 6122 6133 +11
Branches 1493 1494 +1
=========================================
+ Hits 6122 6133 +11
☔ View full report in Codecov by Sentry. |
mtrezza
changed the title
User.linkWith doesn't remove anonymous authParseUser.linkWith doesn't remove anonymous auth
|
Could this be a breaking change? |
|
I don’t think so since it’s a port from the Objective-C SDK and every other SDK has it. I’m more curious how the server acted before this with anonymous data always there if the developer used JS only. |
|
This also fixes an issue, if the linkWith fails the authData was still stored locally / internally to the user. |
mtrezza
reviewed
Aug 29, 2023
mtrezza
changed the title
ParseUser.linkWith doesn't remove anonymous authParseUser.linkWith doesn't remove anonymous auth data
parseplatformorg
pushed a commit
that referenced
this pull request
Aug 29, 2023
# [4.2.0-alpha.7](4.2.0-alpha.6...4.2.0-alpha.7) (2023-08-29) ### Bug Fixes * `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c))
|
🎉 This change has been released in version 4.2.0-alpha.7 |
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 16, 2023
# [4.3.0-beta.1](4.2.0...4.3.0-beta.1) (2023-09-16) ### Bug Fixes * `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c)) * Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c)) ### Features * Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7)) * Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007)) * Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6)) * Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c)) * Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93)) * Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6)) * Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
|
🎉 This change has been released in version 4.3.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 26, 2023
# [4.3.0-alpha.1](4.2.0...4.3.0-alpha.1) (2023-09-26) ### Bug Fixes * `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c)) * Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c)) ### Features * Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7)) * Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007)) * Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6)) * Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c)) * Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93)) * Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6)) * Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
|
🎉 This change has been released in version 4.3.0-alpha.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Nov 16, 2023
# [4.3.0](4.2.0...4.3.0) (2023-11-16) ### Bug Fixes * `ParseUser.linkWith` doesn't remove anonymous auth data ([#2007](#2007)) ([7e2585c](7e2585c)) * Hard-coding of `react-native` path does not work for workspace builds ([#1930](#1930)) ([8222f3c](8222f3c)) ### Features * Add Bytes type to `Parse.Schema` ([#2001](#2001)) ([343d0d7](343d0d7)) * Add Cloud Code context accessibility to `ParseUser.logIn` ([#2010](#2010)) ([2446007](2446007)) * Add support for custom EventEmitter ([#1999](#1999)) ([ca568a6](ca568a6)) * Add support for excluding keys in `ParseQuery.findAll` ([#2000](#2000)) ([012ba4c](012ba4c)) * Add support to invoke a Cloud Function with a custom `installationId` via `Parse.Cloud.run` ([#1939](#1939)) ([eb70b93](eb70b93)) * Allow overriding `Parse.Error` message with custom message via new Core Manager option `PARSE_ERRORS` ([#2014](#2014)) ([be0c8a6](be0c8a6)) * Login with username, password and additional authentication data via `ParseUser.logInWithAdditionalAuth` ([#1955](#1955)) ([2bad411](2bad411))
|
🎉 This change has been released in version 4.3.0 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Calling user.linkWith() doesn't remove the "anonymous" field from the authData object field, causing Parse.AnonymousUtils to still report the user as an Anonymous user.
Closes: #1353