Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Parse.Hooks requests have double forward slash in URL #2441

Merged
merged 6 commits into from
Feb 16, 2025

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 11, 2025

Pull Request

Issue

Closes: #2406

Approach

Remove extra slash

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (52ddaee) to head (b8213fc).
Report is 3 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2441   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6256      6256           
  Branches      1476      1476           
=========================================
  Hits          6256      6256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team February 11, 2025 23:21
@mtrezza
Copy link
Member

mtrezza commented Feb 12, 2025

Could this possibly be a breaking change, thinking about custom parsing of the URI on the server or firewall?

@dplewis
Copy link
Member Author

dplewis commented Feb 12, 2025

@pocketcolin

@mtrezza
Copy link
Member

mtrezza commented Feb 12, 2025

We might want to merge this as a breaking change, make a stable release and then add that to the Parse Sever 8 release as a breaking change. Even though these are internal requests and therefore may be less likely to be restricted by a firewall, it's still possible.

@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Feb 12, 2025
@dplewis dplewis requested a review from mtrezza February 16, 2025 01:28
src/__tests__/Hooks-test.js Outdated Show resolved Hide resolved
@dplewis dplewis requested a review from mtrezza February 16, 2025 01:52
@mtrezza
Copy link
Member

mtrezza commented Feb 16, 2025

BREAKING CHANGE: Internal REST requests for Parse.Hooks use a URL that contains a double forward slash, for example http://localhost/parse//hooks/functions. This release changes the double forward slash to a single forward slash.

@dplewis Is this correct?

@dplewis
Copy link
Member Author

dplewis commented Feb 16, 2025

LGTM!

@mtrezza mtrezza merged commit 1fc520c into parse-community:alpha Feb 16, 2025
12 checks passed
@mtrezza mtrezza removed the request for review from a team February 16, 2025 18:09
parseplatformorg pushed a commit that referenced this pull request Feb 16, 2025
# [6.0.0-alpha.2](6.0.0-alpha.1...6.0.0-alpha.2) (2025-02-16)

### Bug Fixes

* `Parse.Hooks` requests have double forward slash in URL ([#2441](#2441)) ([1fc520c](1fc520c))

### BREAKING CHANGES

* Internal REST requests for `Parse.Hooks` use a URL that contains a double forward slash, for example `http://localhost/parse//hooks/functions`. This release changes the double forward slash to a single forward slash. ([1fc520c](1fc520c))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Feb 16, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Hooks requests have double forward slash in URL (which is an issue for Express 5.x)
3 participants