fix: SDK crash on conversion of double type range values to long type #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… long-type value range and fallback to double type for such cases.
|
@TheFanatr @TobiasPott any update on this? |
…e-range-values-to-long-type
mtrezza
changed the title
Thanks for opening this pull request!
|
…e-range-values-to-long-type
parseplatformorg
pushed a commit
that referenced
this pull request
May 24, 2024
## [3.0.1](3.0.0...3.0.1) (2024-05-24) ### Bug Fixes * SDK crash on conversion of double type range values to long type ([#342](#342)) ([816ba02](816ba02))
|
🎉 This change has been released in version 3.0.1 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request targets the issue of values retrieved from parse-server exceeding the long64 value range mentioned in #339
It handles it by using a fallback to the double type with a higher range as this also would be the type with which the higher values can only be added to the parse-server using the .NET SDK.
It also includes a test checking for long max and min values and the double max and min values and the specific value mentioned in the issue.
@TheFanatr Could you take a look at this PR and give me feedback whether or not to change anything (especially the test part as I'm unsure if it will be sufficient)