Skip to content

refactor: Remove Carthage dependency #1763

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

refactor: Remove Carthage dependency #1763

merged 1 commit into from
Oct 18, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 13, 2023 •
edited
Loading

New Pull Request Checklist

Issue Description

With the removal of Carthage support a lot of legacy code has been leftover. This PR replaces Carthage dependencies with SPM. Carthage is currently breaking the CI

Closes: #1759, #1747, #1729, #1706

Approach

  • Use Facebook SDK via SPM
  • Use Bolts SDK via SPM
  • Fix ParseUI Swift Demo
  • Remove recompile from source .xcodeproj references
  • Remove carthage ci cache
  • Remove cartfile and git submodules
  • Use SPM imports whenever possible

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 13, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dplewis dplewis mentioned this pull request Oct 13, 2023
Closed
2 tasks
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c4998e6) 11.24% compared to head (dadfd0e) 64.23%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1763       +/-   ##
===========================================
+ Coverage   11.24%   64.23%   +52.99%     
===========================================
  Files         195      201        +6     
  Lines       23015    23233      +218     
===========================================
+ Hits         2587    14924    +12337     
+ Misses      20428     8309    -12119
Files Coverage Δ
...kUtils/ParseFacebookUtils/Source/PFFacebookUtils.m 93.91% <ø> (ø)
...nProvider/PFFacebookMobileAuthenticationProvider.m 100.00% <ø> (ø)
...rseFacebookUtilsiOS/Source/PFFacebookUtilsDevice.m 100.00% <ø> (ø)
...S/Tests/Unit/FacebookAuthenticationProviderTests.m 100.00% <ø> (ø)
...seFacebookUtilsiOS/Tests/Unit/FacebookUtilsTests.m 100.00% <ø> (ø)
...eTwitterUtils/Internal/Dialog/PFOAuth1FlowDialog.m 66.21% <ø> (ø)
...erUtils/Internal/PFTwitterAuthenticationProvider.m 90.56% <ø> (ø)
...terUtils/ParseTwitterUtils/Source/PFTwitterUtils.m 17.39% <ø> (ø)
...TwitterUtils/ParseTwitterUtils/Source/PF_Twitter.m 87.43% <ø> (ø)
...ls/Tests/Unit/TwitterAuthenticationProviderTests.m 100.00% <ø> (ø)
... and 9 more

... and 143 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team October 13, 2023 07:15
@dplewis dplewis mentioned this pull request Oct 14, 2023
Open
1 task
@dplewis dplewis requested a review from mtrezza October 14, 2023 17:10
@dplewis
Copy link
Member Author

dplewis commented Oct 14, 2023

@mtrezza This is ready for review and merge.

mtrezza
mtrezza approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza merged commit 5f662b1 into parse-community:master Oct 18, 2023
@dplewis dplewis mentioned this pull request Oct 18, 2023
Closed
14 tasks
@dplewis dplewis deleted the facebook-carthage branch October 18, 2023 21:36
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Apr 8, 2024
eeallen1 added a commit to eeallen1/Parse-SDK-iOS-OSX that referenced this pull request May 6, 2024
@eeallen1
Merge commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02'
53e8034 
* commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02': (86 commits)
  chore(release): 3.0.0 [skip ci]
  ci: Fix release workflow (parse-community#1782)
  feat: Remove `ParseFacebookUtils` and `ParseTwitterUtils` (parse-community#1779)
  feat: Add `PFObject.isDataAvailableForKey` to check if data is available for individual key (parse-community#1756)
  ci: Bump ip from 2.0.0 to 2.0.1 (parse-community#1772)
  ci: Fix failing CI by pinning bundler version (parse-community#1778)
  refactor: Remove Carthage dependency (parse-community#1763)
  refactor: Remove OCMock Carthage dependency (parse-community#1754)
  ci: Run CI on Xcode 15 and macOS 13 (parse-community#1753)
  refactor: Update ruby dependencies (parse-community#1752)
  refactor: Remove framework builder for assets (parse-community#1751)
  chore(release): 2.7.3 [skip ci]
  fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 (parse-community#1749)
  docs: Add changelog note about missing assets (parse-community#1750)
  chore(release): 2.7.2 [skip ci]
  fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS (parse-community#1748)
  ci: Remove publishing release assets (parse-community#1745)
  ci: Fix and build Starter Projects (parse-community#1744)
  chore(release): 2.7.1 [skip ci]
  fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` (parse-community#1739)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bolts causing CI failure
3 participants
@dplewis @parseplatformorg @mtrezza