Skip to content

Don't use transactions by default for internal SDK calls #158

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jun 11, 2021

Using transactions with the latest release of parse-server using mongoDB produces errors while saving. Because of this, transactions are disabled by default. If the developer wants to use transactions internally (was used for saveAll children) in the SDK, they should set useTransactionsInternally=true when configuring the client.

Mongo users should update to Swift SDK 1.8.1 as versions 1.2.1 - 1.8.0 use transactions by default.

Note: transactions work fine with postgres.

  • Disable automatic use of transactions internally
  • Add useTransactionsInternally to ParseConfiguration
  • Update playgrounds
  • Add changelog
  • Prepare for release

Close #157

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #158 (850340b) into main (685f07a) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   81.98%   82.14%   +0.16%     
==========================================
  Files          70       70              
  Lines        6555     6582      +27     
==========================================
+ Hits         5374     5407      +33     
+ Misses       1181     1175       -6     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/Messages.swift 100.00% <ø> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 77.54% <ø> (+0.26%) ⬆️
Sources/ParseSwift/Parse.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Types/Query.swift 93.35% <100.00%> (+1.04%) ⬆️
Sources/ParseSwift/Objects/ParseUser.swift 81.67% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b064000...850340b. Read the comment docs.

@cbaker6 cbaker6 requested a review from TomWFox June 11, 2021 12:39
@cbaker6
Copy link
Contributor Author

cbaker6 commented Jun 11, 2021

@davimacedo @dplewis is this why parse-community/Parse-SDK-JS#1090 isn't merged?

@cbaker6 cbaker6 merged commit 1ee4da1 into main Jun 11, 2021
@cbaker6 cbaker6 deleted the transactionFalseDefault branch June 11, 2021 14:18
@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoding error when saving nested object
1 participant