Skip to content

feat: Add silent log level for Cloud Code #8803

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2024
Merged

feat: Add silent log level for Cloud Code #8803

merged 4 commits into from
Mar 21, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Nov 10, 2023 •
edited
Loading

Pull Request

Issue

Currently Cloud Code logs use JSON.stringify even if they aren't displayed to the console. JSON.stringify is one of the most CPU-intensive and this will improve performance. If you return a large amount of data from a cloud code function JSON.stringify will return Invalid string length error message.

Closes: #8418

Approach

Add silent support to logLevels Parse Server Config. Enable silent cloud code logs by default for the test suite to improve speed.

{
  ...
  logLevels: {
    cloudFunctionSuccess: 'silent',
    cloudFunctionError: 'silent',
    triggerAfter: 'silent',
    triggerBeforeError: 'silent',
    triggerBeforeSuccess: 'silent',
  },
}

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this pull request!

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (907ad42) to head (46f900c).
Report is 1 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #8803      +/-   ##
==========================================
+ Coverage   94.15%   94.17%   +0.01%     
==========================================
  Files         186      186              
  Lines       14679    14688       +9     
==========================================
+ Hits        13821    13832      +11     
+ Misses        858      856       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from mtrezza November 10, 2023 02:45
mtrezza
mtrezza requested changes Nov 11, 2023
View reviewed changes
mtrezza added 2 commits March 21, 2024 15:58
@mtrezza
Merge branch 'alpha' into silent-logs
3acabb4
@mtrezza
refactor
46f900c 
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
@mtrezza mtrezza merged commit 5f81efb into parse-community:alpha Mar 21, 2024
26 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 21, 2024
@semantic-release-bot
chore(release): 7.0.0-alpha.31 [skip ci]
854ac9a 
# [7.0.0-alpha.31](7.0.0-alpha.30...7.0.0-alpha.31) (2024-03-21)

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0-alpha.31

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 21, 2024
parseplatformorg pushed a commit that referenced this pull request Mar 23, 2024
@semantic-release-bot
chore(release): 7.1.0-alpha.1 [skip ci]
dc48be8 
# [7.1.0-alpha.1](7.0.0...7.1.0-alpha.1) (2024-03-23)

### Bug Fixes

* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.1

@dplewis dplewis deleted the silent-logs branch April 12, 2024 07:53
@dplewis dplewis mentioned this pull request Jun 7, 2024
Closed
parseplatformorg pushed a commit that referenced this pull request Jun 30, 2024
@semantic-release-bot
chore(release): 7.1.0-beta.1 [skip ci]
91dde99 
# [7.1.0-beta.1](7.0.0...7.1.0-beta.1) (2024-06-30)

### Bug Fixes

* `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2))
* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))
* Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
* Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
* Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6))
* Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739))
* SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
* Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
* Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a))
* Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8))
* Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496))
* Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 30, 2024
parseplatformorg pushed a commit that referenced this pull request Jun 30, 2024
@semantic-release-bot
chore(release): 7.1.0 [skip ci]
4906644 
# [7.1.0](7.0.0...7.1.0) (2024-06-30)

### Bug Fixes

* `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2))
* `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42))
* Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b))
* Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
* Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6))
* Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739))
* SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4))

### Features

* Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb))
* Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15))
* Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a))
* Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8))
* Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496))
* Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid stringify if log levels are not met
3 participants
@dplewis @parseplatformorg @mtrezza