Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Add exact GPSR #45

Merged
merged 13 commits into from
Mar 4, 2025
Merged

[Feature] Add exact GPSR #45

merged 13 commits into from
Mar 4, 2025

Conversation

chMoussa
Copy link
Collaborator

@chMoussa chMoussa commented Mar 3, 2025

This solves #44. Also reorganizing files into a differentiation folder

@chMoussa chMoussa self-assigned this Mar 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.41%. Comparing base (53be041) to head (3472c8e).

Files with missing lines Patch % Lines
horqrux/differentiation/ad.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   91.07%   91.41%   +0.33%     
==========================================
  Files          25       27       +2     
  Lines        1278     1328      +50     
==========================================
+ Hits         1164     1214      +50     
  Misses        114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chMoussa chMoussa marked this pull request as ready for review March 3, 2025 17:28
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @chMoussa thanks ! Very minor comments, otherwise LGTM.

@chMoussa chMoussa linked an issue Mar 4, 2025 that may be closed by this pull request
@chMoussa chMoussa merged commit 52adc73 into main Mar 4, 2025
6 checks passed
@chMoussa chMoussa deleted the cm/gpsr branch March 4, 2025 20:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exact version of GPSR
3 participants