This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically wraps up two changes in the way this library works without breaking backwards compatibility (badly).
First off, for HSV commands, the Library will only change the channels relevant to the current mode of operation set in the controller, i.e. when controller is setup to work in RGBCW mode, the WW channel will not be affected by sending an HSV-based command.
Second, the library is now able to accept RAW fade commands with individual channels set to -1. These channels will not be changed during fading. This is done by using the current values for those channels when the animation starts execution.
Together with minor changes in the firmware (see PR in esp_rgbww_firmware project), these features will allow for individual control of unused channels, enabling e.g. a single controller to run an RGB LED strip with HSV commands for ambient lighting and two additional single-color strips for lighting up sideboards, shelves or the like.