Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

meta patterns missing? #169

Closed
ivancamilov opened this issue Oct 15, 2015 · 5 comments
Closed

meta patterns missing? #169

ivancamilov opened this issue Oct 15, 2015 · 5 comments
Labels
gap from php 🙈 staged for next release 🏁
Milestone
v1.2.0

Comments

@ivancamilov
Copy link

This might be more of a question than a bug report. In PL-PHP there are two meta patterns for the header and the footer. These are very useful for adding libraries and external dependencies.

However, I do not see a way to do this in patternlab-node. There seem to be separate files for this, namely:

/pattern-header-footer/header.html
/pattern-header-footer/footer.html
/pattern-header-footer/index.mustache
/pattern-header-footer/styleguide.mustache
/pattern-header-footer/viewall.mustache

As far as I can see, you would need to modify all these files to include a dependency such as bootstrap. Is there something I'm missing here? Should pl-node support meta patterns like those on pl-php?
@bmuenzenmeyer
Copy link
Member

In my opinion this is in scope as part of
#133
On Thu, Oct 15, 2015 at 11:30 AM Ivan Camilo Vásquez <
notifications@github.com> wrote:

This might be more of a question than a bug report. In PL-PHP there are two
meta patterns http://patternlab.io/docs/pattern-header-footer.html for
the header and the footer. These are very useful for adding libraries and
external dependencies.

However, I do not see a way to do this in patternlab-node. There seem to
be separate files for this, namely:

/pattern-header-footer/header.html
/pattern-header-footer/footer.html
/pattern-header-footer/index.mustache
/pattern-header-footer/styleguide.mustache
/pattern-header-footer/viewall.mustache

As far as I can see, you would need to modify all these files to include a
dependency such as bootstrap. Is there something I'm missing here? Should
pl-node support meta patterns like those on pl-php?

—
Reply to this email directly or view it on GitHub
#169.

@bmuenzenmeyer bmuenzenmeyer mentioned this issue Oct 15, 2015
Closed
1 task
@bmuenzenmeyer bmuenzenmeyer added this to the v1.0.0 milestone Oct 15, 2015
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Oct 15, 2015
Closed
@ivancamilov
Copy link
Author

that's right, I hadn't seen it on the roadmap. Thanks for adding it!

@bmuenzenmeyer bmuenzenmeyer removed this from the v1.0.0 milestone Nov 25, 2015
@adamtew
Copy link

adamtew commented Dec 7, 2015

Would this be the only way to add different classes to the <body> dynamically? I tried adding using a mustache variable to _patternlab-files/pattern-header-footer/header.html but (probably because it's an .html file and not a .mustache file) it doesn't recognize the variable.

@bmuenzenmeyer
Copy link
Member

@adamtew I am pretty sure this is unsupported, at least for the next couple weeks. I plan to move toward a structure that allows for me to use the mustache starterkit's header as seen in PL PHP, but I am not there yet.

Stay tuned!

@bmuenzenmeyer bmuenzenmeyer mentioned this issue Jan 5, 2016
Closed
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Jan 21, 2016
Closed
6 tasks
@bmuenzenmeyer bmuenzenmeyer added this to the v1.2.0 milestone Jan 21, 2016
@e2tha-e
Copy link
Contributor

e2tha-e commented Feb 10, 2016

@bram Smulders Yes, that's the only way for now, and yes, that's
conflicting with Pattern Lab core. Here's the issue where we're working on
a fix:
#133

Also, might want to comment directly in GitHub so the general public can
see the discussion.

On Wed, Feb 10, 2016 at 9:42 AM, Bram Smulders notifications@github.com
wrote:

How do you guys add custom javascripts to you pages? Is it by adding them
to header.html &/or footer.html? isnt this conflicting with patternlab
itself?

—
Reply to this email directly or view it on GitHub
#169 (comment)
.

@bramsmulders bramsmulders mentioned this issue Feb 29, 2016
Closed
@bmuenzenmeyer bmuenzenmeyer self-assigned this Mar 1, 2016
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Mar 2, 2016
Merged
9 tasks
@bmuenzenmeyer bmuenzenmeyer removed their assignment Mar 7, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
gap from php 🙈 staged for next release 🏁
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
4 participants
@ivancamilov @bmuenzenmeyer @e2tha-e @adamtew