Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement pattern state lowest common denominator #203

Closed
bmuenzenmeyer opened this issue Dec 5, 2015 · 0 comments · Fixed by #284
Closed

Implement pattern state lowest common denominator #203

bmuenzenmeyer opened this issue Dec 5, 2015 · 0 comments · Fixed by #284

Comments

@bmuenzenmeyer
Copy link
Member

While reviewing documentation, I realized I never fully finished the pattern state implementation.

Any pattern that includes a pattern partial that has a lower pattern state will inherit that state. For example, a pattern with the state of inreview that includes a pattern partial with the state of inprogress will have its state overridden and set to inprogress. It will not change to inreview until the pattern partial has a state of inreview or complete.

Code reference: https://github.com/pattern-lab/patternlab-php-core/blob/c2c4bc6a8bda2b2f9c08b197669ebc94c025e7c6/src/PatternLab/PatternData/Helpers/PatternStateHelper.php

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant