Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: remove styleModifiers #1452

Merged
merged 10 commits into from
Dec 28, 2022
Merged

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Dec 24, 2022

Closes #1177

Summary of changes:

Removed styleModifiers, that haven't been mentioned in the documentation any more anyhow.

Remarks:

  • sorry for the visible huge amount of changes within packages/core/test/pseudopattern_hunter_tests.js, that are mainly caused by some code lines being removed, but the file being prettyfied by pretty-quick afterwards.
  • The linters issue / failed pipeline step relates to code lines, that weren't introduced with this PR and would need to get solved independently.

to even also skip that wording of the functionality from our sample files
to even also skip that wording of the functionality from our sample files
to even also skip that wording of the functionality from our sample files
to even also skip that wording of the functionality from our sample files
@mfranzke mfranzke self-assigned this Dec 24, 2022
@mfranzke mfranzke linked an issue Dec 24, 2022 that may be closed by this pull request
@mfranzke mfranzke added the breaking ❗ Use this labe if the change will break the current pattern lab behavior label Dec 24, 2022
@mfranzke mfranzke marked this pull request as ready for review December 28, 2022 06:34
@JosefBredereck JosefBredereck merged commit 454292e into dev Dec 28, 2022
@JosefBredereck JosefBredereck deleted the 1177-deprecate-style-modifiers branch December 28, 2022 20:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking ❗ Use this labe if the change will break the current pattern lab behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Style Modifiers
2 participants