refactor: replaced hogan.js by handlebars #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to keep our codebase up to date, we're replacing the much older hogan.js by handlebars
as they aren't as critical as the uikit-workshop package
JosefBredereck
approved these changes
Dec 28, 2022
JosefBredereck
approved these changes
Dec 28, 2022
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor: replaced hogan.js by handlebars In an effort to keep our codebase up to date, we're replacing the much older hogan.js by handlebars * chore: regenerated yarn.lock file * chore: we don't need to pin that version * chore: let's revert those for the moment as they aren't as critical as the uikit-workshop package Co-authored-by: Josef Bredreck <13408112+JosefBredereck@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
In an effort to keep our codebase up to date, we're replacing the much older hogan.js (last release nine years ago) by handlebars (that we're using anyhow within our codebase).
This should both reduce outdated subdependencies, as well as speed up running the system.
Prerequisite for non-crashing piplines: #1444