Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: js error #1475

Merged
merged 2 commits into from
Jan 30, 2023
Merged

fix: js error #1475

merged 2 commits into from
Jan 30, 2023

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Jan 29, 2023

Summary of changes:

There's a JS error due to the change at https://github.com/pattern-lab/patternlab-node/pull/1102/files#diff-9111c2e0138c935342632437be7178f25322b8f5c86431f2b85f4fe760d32980L96-R111 in which a method parameter has been renamed within the file packages/uikit-workshop/src/scripts/components/pl-nav/nav.js, but not within the method references itself.

Renamed the e parameter to event within two other files as well to align and clarify the naming.

@mfranzke mfranzke self-assigned this Jan 29, 2023
@mfranzke mfranzke requested a review from sghoweri as a code owner January 29, 2023 17:44
@JosefBredereck JosefBredereck merged commit 209b9a1 into dev Jan 30, 2023
@JosefBredereck JosefBredereck deleted the fix-js-error branch January 30, 2023 17:04
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants