Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(twig engine): startup and running problems #1478

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Feb 1, 2023

Closes #1477

Summary of changes:

Added a missing entry (package) to the schema of the twig renderer, which prevented to use a reworked config object (most likely a necessary followup to #1256, as this new field was introduced with this PR).

@mfranzke mfranzke added bug 🐛 twig renderer Issues and updates related to the PHP-based Twig rendering engine labels Feb 1, 2023
@mfranzke mfranzke self-assigned this Feb 1, 2023
@mfranzke mfranzke linked an issue Feb 1, 2023 that may be closed by this pull request
alexandar87
alexandar87 previously approved these changes Feb 1, 2023
Copy link

@alexandar87 alexandar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed it for me.

Copy link

@alexandar87 alexandar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is not passing the build after I run npm run start:

Pattern Engine twig / package @pattern-lab/engine-twig-php: Unexpected token ','

image

@mfranzke
Copy link
Contributor Author

mfranzke commented Feb 1, 2023

Thanks for your feedback. It only seems to be one piece of the solutions (solving the error before the one you're mentioning).

@mfranzke mfranzke changed the title fix: missing schema entry for twig engine fix(twig engine): startup and running problems Feb 1, 2023
@JosefBredereck JosefBredereck marked this pull request as ready for review February 1, 2023 20:16
@JosefBredereck JosefBredereck merged commit e5a1904 into dev Feb 1, 2023
@JosefBredereck JosefBredereck deleted the 1477-startup-error-on-twigrenderer branch February 1, 2023 20:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 twig renderer Issues and updates related to the PHP-based Twig rendering engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startup error on TwigRenderer
3 participants