Skip to content

Remove pattern states #620

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2017
Merged

Remove pattern states #620

merged 3 commits into from
Mar 21, 2017

Conversation

benhalverson
Copy link
Contributor

Addresses #619

Summary of changes:

  • removed setState() from pattern_assembler.js
  • removed patternStates from this repo.
  • Will also remove patternStates from other repos
  • Tests are passing.

@benhalverson benhalverson changed the base branch from dev to dev-3.0 February 10, 2017 16:53
@bmuenzenmeyer bmuenzenmeyer self-assigned this Mar 6, 2017
bmuenzenmeyer
bmuenzenmeyer approved these changes Mar 21, 2017
View reviewed changes
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

Thanks for being patient with me!

@bmuenzenmeyer bmuenzenmeyer merged commit 3e97c82 into pattern-lab:dev-3.0 Mar 21, 2017
bmuenzenmeyer added a commit that referenced this pull request Oct 6, 2017
@bmuenzenmeyer
removes deleted code tests per #620
b545979 
somehow got readded
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benhalverson @bmuenzenmeyer