Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: fix types for number input #10264

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Apr 9, 2024

Refactors the types of the number input so that they will compile when upgrading to TypeScript 5. This is needed to land #10156.

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 9, 2024

Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mfrances17 mfrances17 requested a review from tlabaj April 15, 2024 20:10
@tlabaj tlabaj merged commit 4b75c6e into patternfly:main Apr 19, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@7.4.0-prerelease.1
  • @patternfly/react-code-editor@5.4.0-prerelease.2
  • @patternfly/react-core@5.4.0-prerelease.2
  • @patternfly/react-docs@6.4.0-prerelease.2
  • @patternfly/react-drag-drop@5.4.0-prerelease.2
  • @patternfly/react-icons@5.4.0-prerelease.1
  • demo-app-ts@5.1.1-prerelease.103
  • @patternfly/react-styles@5.4.0-prerelease.1
  • @patternfly/react-table@5.4.0-prerelease.2
  • @patternfly/react-templates@1.1.0-prerelease.2
  • @patternfly/react-tokens@5.4.0-prerelease.1

Thanks for your contribution! 🎉

@jonkoops jonkoops deleted the fix-types-number-input branch April 20, 2024 09:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants