Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Out of date domain list data (was: Version in gemspec wrong) #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamiecobbett
Copy link

It says 0.0.9, but I think it should be 0.0.10.

This prevented me from fully using Bundler's git option.

@larsklevan
Copy link

+1 for this - the domain list data being out of data is preventing correct parsing of top level domains like .do

@wireframe
Copy link

another +1 for this.

we actually just ran into a similar issue with an out of date domain list.

@coreyward
Copy link

+1 — Can we get this pulled in, pretty please?

@danielnc
Copy link

+1

@6
Copy link

6 commented Sep 21, 2012

As a temporary workaround for supporting newer TLDs, you can use:

d = Domainatrix::DomainParser.new("path/to/updated_effective_tld_names.dat")
d.parse("http://abc.do")
# => {:public_suffix=>"do", :domain=>"abc", :subdomain=>"", :scheme=>"http", :host=>"abc.do", :path=>"", :url=>"http://abc.do"}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants