-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WIP: Add copy mode (take 2) #28
Conversation
I think this is a good approach. About the two issues:
|
8fb38e1
to
3ba7ea8
Compare
3ba7ea8
to
94b7486
Compare
I've pushed a new set of commits with the following changes:
Would it be possible to get this PR reviewed and merged, then I will put in another PR to improve the implementation of |
Looks good, just add the |
This is a second attempt at implementing the copy mode function discussed in #26, but using the new
populate
method discussed in #27. I have created a new MR since this is quite different from the first attempt, and I am happy to either close that MR or just overwrite the branch as preffered.Implementing in this way is definitely easier, but there are a couple of things I am unhappy with, specifically:
Caqti_stream.iter_s
is implemented, the error type for the output must match the error type of the input. This doesn't make a lot of sense in the inbound direction, as there are not likely to be any errors in the input stream. Is it worth creating a newiter
method that allows the input and output error types to be the same?populate
methods implemented at once (then I could drop theNot_implemented
error), but then that would mean that other drivers would have to push towards full implementation straight away