Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated stripe_event to 2.3.0 and stripe to 5.14.0 #99

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

jdjkelly
Copy link
Contributor

Otherwise, while I'm here:

  1. Would you accept some other PRs related to tidiness? Ex. a PR to add frozen_string_literal to file headers - infamously has benefits in Ruby, and is currently throwing in your Rubocop config
  2. Would you accept a number of other minor dependency updates? I can configure dependabot on my fork to make this manageable

@jdjkelly
Copy link
Contributor Author

BTW, I'm going to start using my fork here in a quick MVP build out, I'll report back if I hit anything broken

@excid3
Copy link
Collaborator

excid3 commented Jan 22, 2020

Hey @jdjkelly

Just a heads up, the sca branch is probably going to become version 2.0 pretty soon. It's already supporting stripe_event 2.3 as well.

It's rebuilt everything for Stripe to support SCA payments and changed basically everything under the hood. Since it's the most forward compatible, I think it's the right place if you're starting with Pay right now.

@excid3 excid3 merged commit 76d3d28 into pay-rails:master Jan 22, 2020
@jdjkelly
Copy link
Contributor Author

@excid3 awesome, thanks for letting me know - looking forward to more contributions

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants