Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FISH-8728 Refine RE to allow host in jdwp agent address #6724

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented May 16, 2024

Description

This is a fix.

Related:

Testing

New tests

New UT added for host part in address.

Testing Performed

$ uzip -q -d /tmp/payara appserver/distributions/payara/target/payara.zip
$ /tmp/payara/payara6/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start .............
Successfully started the domain : domain1
domain  Location: /tmp/payara/payara6/glassfish/domains/domain1
Log File: /tmp/payara/payara6/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
Debugging is enabled.  The debugging port is: 9009
Command start-domain executed successfully.

Testing Environment

  • GNU/Linux
  • openjdk version "11.0.23" 2024-04-16 + Apache Maven 3.9.6 (build)
  • openjdk version "17.0.11" 2024-04-16 (test)

Documentation

true
The instance is started with JPDA debugging enabled and the
port number for JPDA debugging is displayed.

Notes for Reviewers

@pzygielo pzygielo marked this pull request as ready for review May 16, 2024 11:23
@Pandrex247 Pandrex247 changed the title Refine RE to allow host in jdwp agent address FISH-8728 Refine RE to allow host in jdwp agent address May 17, 2024
@Pandrex247 Pandrex247 added the PR: CLA CLA submitted on PR by the contributor label May 17, 2024
@pzygielo pzygielo marked this pull request as draft May 18, 2024 06:38
@pzygielo

This comment was marked as outdated.

@pzygielo pzygielo marked this pull request as ready for review May 18, 2024 10:31
@kalinchan kalinchan self-requested a review June 26, 2024 08:49
@kalinchan kalinchan merged commit fc25c43 into payara:master Jun 26, 2024
1 check passed
@pzygielo pzygielo deleted the debug-option-display-jdk11+ branch June 26, 2024 09:43
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Jul 2, 2024
FISH-8728 Refine RE to allow host in jdwp agent address
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Jul 5, 2024
FISH-8728 Refine RE to allow host in jdwp agent address
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
PR: CLA CLA submitted on PR by the contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants