FISH-8888 ClearCache command rest endpoint corrected #6850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the parameter name to cache-name as the previous key was already being used which resulted in an error.
|
Jenkins test please |
Pandrex247
reviewed
Aug 2, 2024
...odules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Pielage <pandrex247@hotmail.com>
Pandrex247
reviewed
Aug 2, 2024
There was a problem hiding this comment.
I still seem to get the error listed on the Jira issue.
WSL, Zulu Java 11.0.23, Maven 3.9.8
- Start a clean domain
- Open a private browsing window
- Load http://localhost:4848/management/domain/
- Navigate to http://localhost:4848/management/domain/clear-cache
Cannot find cacheName in clear-cache command model, file a bug
injection failed on fish.payara.nucleus.hazelcast.admin.ClearCache.cacheName with class java.lang.String
|
This change also requires updates to our docs. We need to update the variable name over there too. |
Changed method to POST
Pandrex247
approved these changes
Aug 2, 2024
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Aug 13, 2024
…-rest-endpoint-incorrect FISH-8888 ClearCache command rest endpoint corrected
NotedSalmon
deleted the
FISH-8888-clear-cache-rest-endpoint-incorrect
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FISH-8888 clear-cache command endpoint incorrect.
Description
I changed the parameter name to cache-name as the previous key was already being used which resulted in an error.
Important Info
Blockers
Testing
New tests
Testing Performed
Tested using ./asadmin start-domain --debug domain1. Got the name of a cache from - localhost:4848/management/domain/list-caches and cleared successfully.
Testing Environment
Documentation
Notes for Reviewers