Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FISH-9451 Remove Unnecessary Shim #6884

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Pandrex247
Copy link
Member

@Pandrex247 Pandrex247 commented Aug 13, 2024

Description

Removes a (seemingly) unnecessary transition shim.

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

Start the DAS and loaded the admin console - no OSGi explosions.
Passed TCK: https://jenkins.payara.fish/view/TCKs/job/TCK-Suite/520/ & https://jenkins.payara.fish/view/TCKs/job/JakartaEE-10-TCK/248/

Testing Environment

Windows 11, Zulu JDK 21.0.4, Maven 3.9.8

Documentation

N/A

Notes for Reviewers

None

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 marked this pull request as ready for review August 13, 2024 15:43
@Pandrex247 Pandrex247 changed the title Remove Unnecessary Shim FISH-9451 Remove Unnecessary Shim Aug 14, 2024
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalinchan kalinchan merged commit 885986e into payara:main Aug 28, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants