Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FISH-10318 Add create-system-property command #7133

Merged
merged 3 commits into from
Dec 18, 2024
Merged

FISH-10318 Add create-system-property command #7133

merged 3 commits into from
Dec 18, 2024

Conversation

Viii3
Copy link
Member

@Viii3 Viii3 commented Dec 17, 2024

Description

  • Resolves FISH-10318
    • Adds a create-system-property asadmin command.
    • Adds an associated manpage.
    • Adjusts existing manpages for relevant commands to refer to the new one.

Important Info

Blockers

Testing

New tests

Testing Performed

  • Built the server and used the command to create a new system property.
  • Verified the property exists with the list-system-properties command.

Testing Environment

Maven version: 3.9.6
Java version: 11.0.23, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

Documentation

Notes for Reviewers

@Viii3 Viii3 force-pushed the FISH-10318-System-Property branch from 12407ba to 4e97174 Compare December 17, 2024 12:13
@Pandrex247 Pandrex247 self-requested a review December 18, 2024 14:33
@Pandrex247 Pandrex247 dismissed their stale review December 18, 2024 14:34

Feedback addressed - rereviewing

Pandrex247
Pandrex247 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing

nucleus/core/kernel/src/main/manpages/fish/payara/enterprise/admin/create-system-property.1 Outdated Show resolved Hide resolved
@Viii3 Viii3 merged commit 092bb72 into payara:main Dec 18, 2024
1 check passed
Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jan 7, 2025
@Pandrex247
Revert "Merge pull request payara#7133 from Viii3/FISH-10318-System-P…
8498842 
…roperty"

This reverts commit 092bb72, reversing
changes made to 00338c9.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Pandrex247 Pandrex247 Pandrex247 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viii3 @Pandrex247