Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FISH-8859 FISH-10015 : design graceful shutdown of docker images community 6 #7173

Conversation

luiseufrasio
Copy link
Contributor

Description

Implement Docker Images Graceful Shutdown Support

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

Run in WSL:

  1. export JAVA_HOME=/usr/lib/jvm/zulu11-ca-amd64 && export PATH=${JAVA_HOME}/bin:${PATH}
  2. cd Payara
  3. mvn clean install -DskipTests
  4. cd appserver/extras/docker-images/server-full
  5. mvn clean package
  6. cd target/docker
  7. docker build -t payara/server-full:local -f ./payara/server-full/build/Dockerfile.jdk11 ./payara/server-full/tmp/docker-build/
  8. docker run -it -p 8080:8080 -p 4848:4848 --name payara_docker payara/server-full:local
  9. open another WSL Tab
  10. docker ps -a
  11. docker stop <container_id>, it works with only the id's 3 first chars
  12. It should show us the logs of stop-domain with a gracefull shutdown at the ORIGINAL WSL tab

Testing Environment

Zulu JDK 11.0.11 on Ubuntu 22 with Maven 3.9.0

@luiseufrasio luiseufrasio changed the title FISH-10015 : SCRIPT_DIR is not necessary FISH-8859 FISH-10015 : SCRIPT_DIR is not necessary Jan 28, 2025
Pandrex247
Pandrex247 previously approved these changes Jan 29, 2025
@Pandrex247 Pandrex247 dismissed their stale review January 29, 2025 09:51

Hol' up...

Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docker test for Payara Micro is broken (not by this change, by your previous PR):

[ERROR] Failures:
[ERROR]   PayaraMicroTest.testServlet:112 Multiple Failures (1 failure)
        java.io.FileNotFoundException: http://localhost:49498/TestServletWebApp

@luiseufrasio
Copy link
Contributor Author

The Docker test for Payara Micro is broken (not by this change, by your previous PR):

[ERROR] Failures:
[ERROR]   PayaraMicroTest.testServlet:112 Multiple Failures (1 failure)
        java.io.FileNotFoundException: http://localhost:49498/TestServletWebApp

Back to original solution... Tests are passing again.

@luiseufrasio luiseufrasio changed the title FISH-8859 FISH-10015 : SCRIPT_DIR is not necessary FISH-8859 FISH-10015 : design graceful shutdown of docker images community 6 Jan 29, 2025
@luiseufrasio luiseufrasio merged commit ca4fdcd into payara:main Jan 31, 2025
1 check passed
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Feb 18, 2025
…aceful-shutdown-of-docker-images

FISH-8859 FISH-10015 : design graceful shutdown of docker images community 6
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants