Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix schedule POST deserialization #69

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

nickfarrow
Copy link
Collaborator

Reordering the form causes a deserialization error on

let request: ChannelBatch = conf.deserialize_bytes(&bytes)?;

Not sure what is enforcing the error but let's just leave in this order for now

@nickfarrow nickfarrow changed the title Fix schedule post Fix schedule POST deserialization Nov 17, 2022
@nickfarrow
Copy link
Collaborator Author

Fixes this:
image

@DanGould
Copy link
Contributor

This code isn't pushed to prod yet. Rather than push a bandaid, let's find and fix the root of the problem

@DanGould
Copy link
Contributor

AFAICT this is because the deserialization depth was set to 2 when we're going deeper with channels[0][node].

I guess channels[0] got flattened to 1 depth somehow on the ordering, even if the semantics were wrong. Rebased to fix based on depth without reverting the UI (default is 16 anyhow)

@DanGould DanGould merged commit 25409a1 into payjoin:master Nov 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants