fix(ui): disable publish button if form is autosaving #11343
+60
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessioGr
requested review from
jmikrut,
jacobsfletch and
JarrodMFlesch
as code owners
| @@ -108,6 +110,13 @@ export const Autosave: React.FC<Props> = ({ id, collection, global: globalDoc }) | |||
| return | |||
| } | |||
|
|
|||
| // Do not autosave if the form is already processing (e.g. if the user clicked the publish button | |||
| // right before this autosave runs), as parallel updates could ause conflicts | |||
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6648
This PR introduces a new
useFormBackgroundProcessinghook and a correspondingsetBackgroundProcessingfunction in theuseFormhook.Unlike
useFormProcessing/setProcessing, which mark the entire form as read-only, this new approach only disables the Publish button during autosaving, keeping form fields editable for a better user experience.I named it
backgroundProcessingbecause it should run behind the scenes without disrupting the user. You could argue that it is a bit more generic than something likeisAutosaving, but it signals intent: Background = do not disrupt the user.